Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bindings/cpp): update CMakeLists.txt to prepare release #3030

Merged
merged 2 commits into from
Sep 11, 2023
Merged

chore(bindings/cpp): update CMakeLists.txt to prepare release #3030

merged 2 commits into from
Sep 11, 2023

Conversation

silver-ymz
Copy link
Member

@silver-ymz silver-ymz commented Sep 11, 2023 •
edited
Loading

Update:

  • set test and docs as an option in CMakeLists.txt so that library users don't have to build test binary and documents.
  • run cargo build --release when setting CMAKE_BUILD_TYPE to Release
  • fix missing headers when using it as external library

@silver-ymz
typos
1a68aca 
Signed-off-by: silver-ymz <[email protected]>
Xuanwo
Xuanwo approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 40d8793 into main Sep 11, 2023
@Xuanwo Xuanwo deleted the cpp-prepare-release branch September 11, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silver-ymz @Xuanwo