Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move all fixtures from core/src/services/{service} to top-level fixtures/{service} #3088

Merged
merged 9 commits into from
Sep 15, 2023
Merged

refactor: move all fixtures from core/src/services/{service} to top-level fixtures/{service} #3088

merged 9 commits into from
Sep 15, 2023

Conversation

G-XD
Copy link
Contributor

@G-XD G-XD commented Sep 15, 2023

Related: #3066

@G-XD G-XD requested review from Xuanwo and PsiACE as code owners September 15, 2023 08:32
Xuanwo
Xuanwo approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

dqhl76
dqhl76 approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@dqhl76 dqhl76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xuanwo Xuanwo merged commit 78c1e07 into apache:main Sep 15, 2023
@G-XD G-XD deleted the fixtures_migration branch September 15, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@dqhl76 dqhl76 dqhl76 approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@G-XD @Xuanwo @dqhl76