Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(service/tikv): rename Backend to TikvBackend #3545

Merged
merged 4 commits into from
Nov 9, 2023
Merged

chore(service/tikv): rename Backend to TikvBackend #3545

merged 4 commits into from
Nov 9, 2023

Conversation

caicancai
Copy link
Member

@caicancai caicancai commented Nov 9, 2023

I'm sorry, there were some regulations that weren't aware of
fix: #3512

@caicancai caicancai requested a review from Xuanwo as a code owner November 9, 2023 02:11
@caicancai caicancai marked this pull request as draft November 9, 2023 02:14
@caicancai caicancai closed this Nov 9, 2023
@caicancai caicancai deleted the fix branch November 9, 2023 02:21
@caicancai caicancai restored the fix branch November 9, 2023 02:25
@caicancai caicancai reopened this Nov 9, 2023
@Xuanwo
Copy link
Member

Xuanwo commented Nov 9, 2023

Hi, please use a meaningful name as your PR title.

@caicancai caicancai changed the title refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer refactor(service/tikv): rename Backend to TikvBackend Nov 9, 2023
@caicancai
Copy link
Member Author

caicancai commented Nov 9, 2023

Hi, please use a meaningful name as your PR title.

ok. Thank you for reminding me

@caicancai caicancai marked this pull request as ready for review November 9, 2023 05:55
@Xuanwo Xuanwo changed the title refactor(service/tikv): rename Backend to TikvBackend chore(service/tikv): rename Backend to TikvBackend Nov 9, 2023
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 540cc68 into apache:main Nov 9, 2023
qingwen220 pushed a commit to qingwen220/incubator-opendal that referenced this pull request Nov 15, 2023
* refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer

* refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer

* refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer
qingwen220 pushed a commit to qingwen220/incubator-opendal that referenced this pull request Nov 15, 2023
* refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer

* refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer

* refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants