-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(service/tikv): rename Backend to TikvBackend #3545
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyanhanx
reviewed
Nov 9, 2023
Hi, please use a meaningful name as your PR title. |
caicancai
changed the title
refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer
refactor(service/tikv): rename Backend to TikvBackend
Nov 9, 2023
ok. Thank you for reminding me |
Xuanwo
changed the title
refactor(service/tikv): rename Backend to TikvBackend
chore(service/tikv): rename Backend to TikvBackend
Nov 9, 2023
Xuanwo
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
qingwen220
pushed a commit
to qingwen220/incubator-opendal
that referenced
this pull request
Nov 15, 2023
* refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer * refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer * refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer
qingwen220
pushed a commit
to qingwen220/incubator-opendal
that referenced
this pull request
Nov 15, 2023
* refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer * refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer * refactor(service/tikv): Add TikvConfig to implement ConfigDeserializer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry, there were some regulations that weren't aware of
fix: #3512