Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(object_store): upgrade object_store to 0.7. #3713

Merged
merged 2 commits into from
Dec 5, 2023
Merged

refactor(object_store): upgrade object_store to 0.7. #3713

merged 2 commits into from
Dec 5, 2023

Conversation

youngsofun
Copy link
Contributor

@youngsofun youngsofun commented Dec 5, 2023 •
edited
Loading

  1. the api change since 0.6
  2. impl ObjectStore:list_with_offset by the way. because delta read need it.
  3. disable get_opts for now instead of return wrong result.

@youngsofun youngsofun changed the title upgrade object_store to 0.7. refactor: upgrade object_store to 0.7. Dec 5, 2023
@youngsofun youngsofun changed the title refactor: upgrade object_store to 0.7. refactor(object_store): upgrade object_store to 0.7. Dec 5, 2023
Xuanwo
Xuanwo reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

integrations/object_store/src/lib.rs Show resolved Hide resolved
integrations/object_store/src/lib.rs Outdated Show resolved Hide resolved
integrations/object_store/src/lib.rs Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit ba3fc45 into apache:main Dec 5, 2023
19 checks passed
@Xuanwo
Copy link
Member

Xuanwo commented Dec 5, 2023

Hi, @suyanhanx, the token for gdrive seems expired. Would you like to update it again? Thanks.

@linhr linhr mentioned this pull request Sep 12, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youngsofun @Xuanwo