-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(core): add tests for versioning #5132
Conversation
In #5106, I didn't address the |
I believe they should be included when users have |
Ok. And I want to discuss some additional details about this issue. |
If |
I believe we should make our best effort to fetch them since it doesn't affect the result. It's fine to attempt fetching even if |
what about |
Well, that makes sense. Let's return unsupported for all those cases. |
…g, list_with_versioning_capabilities
…version returns Ok
413a432
to
fc794d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks a lot.
Which issue does this PR close?
part of: #2611
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?