Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove the token of codspeed #5283

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Nov 4, 2024

Which issue does this PR close?

None

Rationale for this change

Publib repo doesn't need a token. We can allow forked repo to upload data by remove the token.

What changes are included in this PR?

Are there any user-facing changes?

@Xuanwo Xuanwo requested a review from PsiACE as a code owner November 4, 2024 15:20
@Xuanwo Xuanwo requested a review from dqhl76 November 4, 2024 15:23
Copy link

codspeed-hq bot commented Nov 4, 2024

CodSpeed Performance Report

Merging #5283 will degrade performances by 11.34%

Comparing remove-secrets-for-benchmark (66aa09d) with main (71c12a3)

Summary

❌ 1 regressions
✅ 72 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main remove-secrets-for-benchmark Change
concurrent 4 410.2 µs 462.7 µs -11.34%

Copy link
Member

@dqhl76 dqhl76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I didn't notice that. That LGTM.

@dqhl76 dqhl76 merged commit a2149b2 into main Nov 4, 2024
13 of 14 checks passed
@dqhl76 dqhl76 deleted the remove-secrets-for-benchmark branch November 4, 2024 15:39
@dqhl76
Copy link
Member

dqhl76 commented Nov 4, 2024

Merging #5283 will degrade performances by 11.34%

I found codspeed give a regression alert. It could be config in the setting. I will watch for some days to adjust the threshold. For now, it is 10%.
image

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 4, 2024

Hi, @dqhl76 is there a way to disable CodSpeed Performance Analysis fail on our main branch? We want to check the perf on PR but don't want it to break our CI.

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 4, 2024

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants