Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core)!: Remove the range writer that has never been used #5323

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Nov 14, 2024

Which issue does this PR close?

None

Rationale for this change

Dead Code

What changes are included in this PR?

This PR will remove RangeWriter which never been used

Are there any user-facing changes?

@Xuanwo Xuanwo requested review from koushiro, hoslo and G-XD November 14, 2024 11:31
@koushiro koushiro changed the title refactor(core)!: Remove range writer which never been used refactor(core)!: Remove the range writer that has never been used Nov 14, 2024
Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #5323 will degrade performances by 18.88%

Comparing remove-range-writer (dbf95bb) with main (104727c)

Summary

⚡ 1 improvements
❌ 8 regressions
✅ 64 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main remove-range-writer Change
256 KiB * 1000k chunk 125.3 ns 154.4 ns -18.88%
256 KiB * 1000k truncate 216.7 ns 245.8 ns -11.86%
256 KiB * 100k chunk 125.3 ns 154.4 ns -18.88%
256 KiB * 100k truncate 216.7 ns 245.8 ns -11.86%
256 KiB * 10k chunk 154.4 ns 183.6 ns -15.89%
256 KiB * 10k truncate 216.7 ns 245.8 ns -11.86%
256 KiB * 1k chunk 125.3 ns 154.4 ns -18.88%
256 KiB * 1k truncate 216.7 ns 245.8 ns -11.86%
concurrent 8 365.4 µs 327.3 µs +11.62%

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 14, 2024

Thank you @koushiro for the review!

@Xuanwo Xuanwo merged commit 8eeec44 into main Nov 14, 2024
275 checks passed
@Xuanwo Xuanwo deleted the remove-range-writer branch November 14, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants