Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(python): fix pyproject meta file #5348

Merged
merged 1 commit into from
Nov 20, 2024
Merged

build(python): fix pyproject meta file #5348

merged 1 commit into from
Nov 20, 2024

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Nov 19, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

version should be defined or it should be included in project.dynamic

What changes are included in this PR?

Are there any user-facing changes?

@trim21 trim21 marked this pull request as ready for review November 19, 2024 21:39
messense
messense approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trim21
Copy link
Contributor Author

trim21 commented Nov 20, 2024

or we can move version from cargo.toml to pyproject.toml but i don't know how binding version are managed here

@Xuanwo Xuanwo changed the title fix pyproject meta file build(python): fix pyproject meta file Nov 20, 2024
Xuanwo
Xuanwo approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @trim21 for this PR and thank you @messense's review.

We prefer keep version in Cargo.toml to make our release easier.

@Xuanwo Xuanwo merged commit b0befb7 into apache:main Nov 20, 2024
60 checks passed
@trim21 trim21 deleted the fix-py-project-file branch November 20, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@messense messense messense approved these changes

@Zheaoli Zheaoli Awaiting requested review from Zheaoli Zheaoli is a code owner

Assignees
No one assigned
Labels
releases-note/build releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trim21 @messense @Xuanwo