Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(integration/object_store): add example for datafusion #5543

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

meteorgan
Copy link
Contributor

@meteorgan meteorgan commented Jan 13, 2025

Which issue does this PR close?

Part of: #4599

Rationale for this change

What changes are included in this PR?

add an example to demonstrate querying data in a S3 bucket using DataFusion and object_store_opendal

Are there any user-facing changes?

@Xuanwo Xuanwo changed the title example(integration/object_store): add example for datafusion docs(integration/object_store): add example for datafusion Jan 13, 2025
@meteorgan meteorgan marked this pull request as ready for review January 13, 2025 12:12
@Xuanwo
Copy link
Member

Xuanwo commented Jan 13, 2025

Hi, this example is excellent. Could we include it in the README to make it more visible?

@meteorgan
Copy link
Contributor Author

Hi, this example is excellent. Could we include it in the README to make it more visible?

Ok, I'll add it later.

@meteorgan
Copy link
Contributor Author

Forgot to attach the result of this example:
Xnip2025-01-13_19-58-49

Copy link

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it -- thank you @meteorgan (and @Xuanwo for the pointer)

let op = Operator::new(builder)
.map_err(|err| DataFusionError::External(Box::new(err)))?
.finish();
let store = object_store_opendal::OpendalStore::new(op);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ this is very cool

@meteorgan meteorgan force-pushed the object_store_examples branch from 43704b5 to 45e0dde Compare January 14, 2025 16:26
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, thank you @meteorgan

@Xuanwo Xuanwo merged commit a8b793b into apache:main Jan 15, 2025
34 checks passed
@meteorgan meteorgan deleted the object_store_examples branch January 15, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants