Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update runtimes for upstream changes. #227

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Update runtimes for upstream changes. #227

merged 1 commit into from
Jun 18, 2018
+94 −30

Conversation

rabbah
Copy link
Member

@rabbah rabbah commented Jun 18, 2018 •
edited
Loading

Updated runtimes.json per apache/openwhisk#3680.

@dgrove-oss
Copy link
Member

Do we need the same changes to runtimes-minimal-travis.json ?

@rabbah
Copy link
Member Author

rabbah commented Jun 18, 2018

oy.

@dgrove-oss
Copy link
Member

Something additional needs to be fixed in invoker configuration, I pulled the invoker logs from one of the failing runs, and I see


[2018-06-18T19:58:06.884Z] [ERROR] [#tid_sid_invokerHealth] [DockerClientWithFileAccess] code: 125 , stdout: , stderr: Unable to find image 'nodejs6action:latest' locally
/usr/bin/docker: Error response from daemon: pull access denied for nodejs6action, repository does not exist or may require 'docker login'.
See '/usr/bin/docker run --help'. [marker:invoker_docker.run_error:67883:604]

dgrove-oss
dgrove-oss approved these changes Jun 18, 2018
View reviewed changes
Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgrove-oss dgrove-oss merged commit cb9c3f5 into apache:master Jun 18, 2018
@rabbah
Copy link
Member Author

rabbah commented Jun 19, 2018

I don't think my PR was complete - this playbook needs adjustments:

https://github.com/apache/incubator-openwhisk-deploy-kube/blob/master/docker/docker-pull/pull_images.yml

@dgrove-oss
Copy link
Member

follow up changes in #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrove-oss dgrove-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rabbah @dgrove-oss