Add nodejs:10 to default set of runtimes for k8s #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csantanapr
changed the title
dgrove-oss
requested changes
Nov 19, 2018
helm/openwhisk/runtimes.json
Outdated
| "image": { | ||
| "prefix": "openwhisk", | ||
| "name": "action-nodejs-v10", | ||
| "tag": "d967ebe" |
There was a problem hiding this comment.
This tag doesn't exist in dockerhub for action-nodejs-v10. Current available tags are e892cd8 or 586f84e.
There was a problem hiding this comment.
it was a copy paste error from nodejs8, Are we pinning now?
You don't like to live on the bleeding edge?
There was a problem hiding this comment.
Thanks. Yeah, the chart is much more useful if the deployments using it are repeatable. So I've switched to pinning all docker tags & git clones, with a plan of updating with known good versions on a frequent basis (roughly weekly...).
dgrove-oss
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to apache/openwhisk#4123