-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a multi-architecture Docker image for the runtime #28
Conversation
Hmm... as expected, the encrypted keys are presenting some difficulty, in part because of quoting issues. I’ll look at it more closely in the morning when I have slept. |
Re-based and removed superfluous changes to testing processes. |
@csantanapr @rabbah Could you give this a review? Here's the follow-on items list:
Note: Documentation changes are dependent on apache/openwhisk#3496 |
@@ -63,11 +63,8 @@ ansible/roles/nginx/files/*cert.pem | |||
|
|||
# .zip files must be explicited whitelisted | |||
*.zip | |||
!tests/dat/actions/blackbox.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because these dont exist in this repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an emoji for “Hey I just left it there because you guys always knock me for changing too many things at once?”. 😛
Use gradle-docker-plugin and (my) gradle-fatmanifest-plugin to create a multi-architecture manifest for the nodejs runtime. The process relies on having PPC64LE and S390X docker environments available. The TLS certificates for these environments are encrypted in the repo. The GPG key for them has been encrypted as well, accessible by my fork and by ‘apache/incubator-openwhisk-runtime-nodejs’. Other forks can be given access — it is necessary to add encryption’s of the GPG key and the JSON specifying the repository locations in the .travis.yml. They will also need to provide their own Docker registry (or we need to do some additional work to support using an ephemeral registry — the problem is that we then need to add a capability to the gradle-fatmanifest-plugin to copy blobs between registries, not a pretty proposition.
I’m going to try to add some documentation of the process to the files and to a docs folder, but I wanted to get review started now, as I suspect there’ll be many questions and those will in turn inform the documentation.
This is a key milestone in being able to run OpenWhisk in a multi-architecture environment. Being able to take advantage of it will eventually depend upon OpenWhisk Issue 3412 and other following changes to do away with hard-coding. (See OpenWhisk PR 3407 for an outline of upcoming changes.)
There is a severe backlog of cleanup coming, too. Issue to follow to document needed cleanup.
@csantanapr