-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubectl version in invoker Dockerfile #3772
Conversation
Update version of kubectl executable in invoker Dockerfile from 1.6.4 to 1.8.13 (most recent release in Kubernetes 1.8.x line). Match minimum Kubernetes version of 1.8.x from openwhisk-deploy-kube.
@bbrowning - see any problem with updating the kubectl version embedded in the invoker docker image? Note: the |
Codecov Report
@@ Coverage Diff @@
## master #3772 +/- ##
=======================================
Coverage 75.38% 75.38%
=======================================
Files 132 132
Lines 6183 6183
Branches 392 392
=======================================
Hits 4661 4661
Misses 1522 1522 Continue to review full report at Codecov.
|
@bbrowning and @bwmcadams are you ok with the bump of kubectl in the invoker image to 1.8.x? If so, could you merge this PR? |
@dgrove-oss which Kube version are we targetting with the invoker image? IBM Cloud Kubernetes service is on Kube 1.10 at the moment... |
the open deploy-kube project nominally supports Kube 1.8, 1.9, and 1.10. The kubectl embedded in the invoker image is only used in a couple of code paths in the KubernetesContainerFactory. We actually should get rid of it entirely, but it will take a little work in the KubernetesClient code used by the KubeContainerFactory. |
Ok, thanks. So I'm also asking because
|
Bumping the Kube version makes sense to me. I'll let @bwmcadams do the review and merge dance. Thanks! |
It turned out to be pretty easy to implement the last couple of operations using the rest client, so we don't even need the kubectl exectuable in the invoker image anymore. Closing this in favor of #3963 |
Update version of kubectl executable in invoker Dockerfile
from 1.6.4 to 1.8.13 (most recent release in Kubernetes 1.8.x line).
Match minimum Kubernetes version of 1.8.x from openwhisk-deploy-kube.
Description
Related issue and scope
My changes affect the following components
Types of changes
Checklist: