Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubectl version in invoker Dockerfile #3772

Closed
wants to merge 1 commit into from

Conversation

dgrove-oss
Copy link
Member

Update version of kubectl executable in invoker Dockerfile
from 1.6.4 to 1.8.13 (most recent release in Kubernetes 1.8.x line).
Match minimum Kubernetes version of 1.8.x from openwhisk-deploy-kube.

Description

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • [ x] Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

Sorry, something went wrong.

Partially verified

This commit is signed with the committer’s verified signature.
spydon’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Update version of kubectl executable in invoker Dockerfile
from 1.6.4 to 1.8.13 (most recent release in Kubernetes 1.8.x line).
Match minimum Kubernetes version of 1.8.x from openwhisk-deploy-kube.
@dgrove-oss
Copy link
Member Author

dgrove-oss commented Jun 15, 2018

@bbrowning - see any problem with updating the kubectl version embedded in the invoker docker image?

Note: the kubectl executable in the invoker's docker image is only used with the KubernetesContainerFactory.

@codecov-io
Copy link

Codecov Report

Merging #3772 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3772   +/-   ##
=======================================
  Coverage   75.38%   75.38%           
=======================================
  Files         132      132           
  Lines        6183     6183           
  Branches      392      392           
=======================================
  Hits         4661     4661           
  Misses       1522     1522

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c816aa...ebe0569. Read the comment docs.

@dgrove-oss dgrove-oss requested a review from bwmcadams July 13, 2018 20:35
@markusthoemmes markusthoemmes added review Review for this PR has been requested and yet needs to be done. kubernetes labels Jul 23, 2018
@dgrove-oss
Copy link
Member Author

@bbrowning and @bwmcadams are you ok with the bump of kubectl in the invoker image to 1.8.x? If so, could you merge this PR?

@sven-lange-last
Copy link
Member

@dgrove-oss which Kube version are we targetting with the invoker image? IBM Cloud Kubernetes service is on Kube 1.10 at the moment...

@dgrove-oss
Copy link
Member Author

the open deploy-kube project nominally supports Kube 1.8, 1.9, and 1.10.

The kubectl embedded in the invoker image is only used in a couple of code paths in the KubernetesContainerFactory. We actually should get rid of it entirely, but it will take a little work in the KubernetesClient code used by the KubeContainerFactory.

@sven-lange-last
Copy link
Member

Ok, thanks. So kubectl version 1.8 is a reasonable choice.

I'm also asking because kubectl 1.11 introduced an experimental kubectl wait command which is pretty helpful for scripting.

kubectl wait --help
Experimental: Wait for one condition on one or many resources

Options:
      --all-namespaces=false: If present, list the requested object(s) across all namespaces. Namespace in current
context is ignored even if specified with --namespace.
  -f, --filename=[]: identifying the resource.
      --for='': The condition to wait on: [delete|condition=condition-name].
  -o, --output='': Output format. One of:
json|yaml|wide|name|custom-columns=...|custom-columns-file=...|go-template=...|go-template-file=...|jsonpath=...|jsonpath-file=...
See custom columns [http://kubernetes.io/docs/user-guide/kubectl-overview/#custom-columns], golang template
[http://golang.org/pkg/text/template/#pkg-overview] and jsonpath template
[http://kubernetes.io/docs/user-guide/jsonpath].
  -R, --recursive=true: Process the directory used in -f, --filename recursively. Useful when you want to manage related
manifests organized within the same directory.
  -l, --selector='': Selector (label query) to filter on, supports '=', '==', and '!='.(e.g. -l key1=value1,key2=value2)
      --timeout=30s: The length of time to wait before giving up.  Zero means check once and don't wait, negative means
wait for a week.

Usage:
  kubectl wait resource.group/name [--for=delete|--for condition=available] [options]

Use "kubectl options" for a list of global command-line options (applies to all commands).

@bbrowning
Copy link
Contributor

Bumping the Kube version makes sense to me. I'll let @bwmcadams do the review and merge dance.

Thanks!

@dgrove-oss
Copy link
Member Author

It turned out to be pretty easy to implement the last couple of operations using the rest client, so we don't even need the kubectl exectuable in the invoker image anymore. Closing this in favor of #3963

@dgrove-oss dgrove-oss closed this Aug 14, 2018
@dgrove-oss dgrove-oss deleted the bump-kubectl-version branch August 17, 2018 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kubernetes review Review for this PR has been requested and yet needs to be done.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants