-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/dev - updated intellij script to start controller and invoker locally #4142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would simplify debugging some of the Invoker related flows in IDE. Some minor changes otherwise good to go
...r/src/main/scala/org/apache/openwhisk/core/containerpool/docker/DockerContainerFactory.scala
Outdated
Show resolved
Hide resolved
...r/src/main/scala/org/apache/openwhisk/core/containerpool/docker/DockerContainerFactory.scala
Outdated
Show resolved
Hide resolved
...r/src/main/scala/org/apache/openwhisk/core/containerpool/docker/DockerContainerFactory.scala
Outdated
Show resolved
Hide resolved
...r/src/main/scala/org/apache/openwhisk/core/containerpool/docker/DockerContainerFactory.scala
Outdated
Show resolved
Hide resolved
...main/scala/org/apache/openwhisk/core/containerpool/docker/DockerForMacContainerFactory.scala
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4142 +/- ##
==========================================
+ Coverage 77.91% 80.82% +2.91%
==========================================
Files 151 152 +1
Lines 7277 7391 +114
Branches 468 473 +5
==========================================
+ Hits 5670 5974 +304
+ Misses 1607 1417 -190
Continue to review full report at Codecov.
|
…ocally (apache#4142) * tools/dev - updated intellij script for docker-compose * Added support for docker for mac * log-limit is 0 to avoid collection logs * updates for wskdev with ansible
Description
This PR updates
gradlew :tools:dev:intellij
to work with docker-compose and ansible locally . It basically makes the generation of IntelliJ configuration a bit more generic.In addition, it adds a container factory for Mac, to expose action container ports on the host, as otherwise the invoker can't make HTTP requests to the action containers. Docker for Mac doesn't expose any direct route to containers.
My changes affect the following components
Types of changes
Checklist: