Revert "Proposing Lean OpenWhisk (#3886)" #4161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d4a190c.
The reason I'm reverting the commit is because while I can do a local path to mirror some of the changes in the main (fat?) loadbalancer, there is already a fair bit of divergence in the two load balancers because the lean version clones and owns the code and so it's prone to such slippage.
There is a cleaner organization which allows a common LB class which implements much of the logic that is shared between the two implementations. I started to do this on this branch https://github.com/apache/incubator-openwhisk/compare/master...rabbah:patch?expand=1 but it's clear it will take me a bit more time and we shouldn't break all the repos in the meantime.
I further suggest in the refactoring that the lean LB actually implements identity actors for the invoker pool health and feeds so that there's less reason to diverge or special case some of the code. It's best to have one version of this code because it's functionally critical.
@kpavel Sorry that I didn't get to review the code again more recently before it was merged, but I'm happy to help re-introduce this contribution with an improved organization as suggested here if you're agreeable.