.NET Core 2.2 Runtime

[shawnallen85]

Description

Updated runtimes.json to include the .NET Core 2.2 runtime container.

Additional documentation for creating .NET Core 2.2 actions.

Standard and Unicode tests for .NET Core 2.2.

My changes affect the following components

• API
• Controller
• Message Bus (e.g., Kafka)
• Loadbalancer
• Invoker
• Intrinsic actions (e.g., sequences, conductors)
• Data stores (e.g., CouchDB)
• Tests
• Deployment
• CLI
• General tooling
• Documentation

Types of changes

• Bug fix (generally a non-breaking change which closes an issue).
• Enhancement or new feature (adds new functionality).
• Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

• I signed an Apache CLA.
• I reviewed the style guides and followed the recommendations (Travis CI will check :).
• I added tests to cover my changes.
• My changes require further changes to the documentation.
• I updated the documentation where necessary.

[rabbah]

this file is not needed tests/dat/actions/helloDotNet.bin.
Missing link from https://github.com/apache/incubator-openwhisk/blob/master/docs/actions.md#languages-and-runtimes.
Minor suggestions otherwise.

👍 otherwise.

[rabbah]

the # here needs to be escaped or wrapped in quotes otherwise interpreted as a comment in some terminals.

[csantanapr]

I think this should be "application/octet-stream"

[csantanapr]

Suggested change

	"attachmentType": "application/zip"
	"attachmentType": "application/octet-stream"

[rabbah]

@chetanmeh can you review this change?

All of the attachments in the manifest are text/plain which iirc is because we store all blobs as 64 encoded text. So should this also be plain/text?

[csantanapr]

Actually is text/plain

[rabbah]

@shawnallen85 you need one more change:

diff --git a/tests/src/test/scala/system/basic/WskUnicodeTests.scala b/tests/src/test/scala/system/basic/WskUnicodeTests.scala
index 611d8baa..08b95e47 100644
--- a/tests/src/test/scala/system/basic/WskUnicodeTests.scala
+++ b/tests/src/test/scala/system/basic/WskUnicodeTests.scala
@@ -52,6 +52,7 @@ class WskUnicodeTests extends TestHelpers with WskTestHelpers with JsHelpers wit
   def main(kind: String): Option[String] = {
     kind match {
       case "java" => Some("Unicode")
+      case s if (s.contains("dotnet")) => Some("Apache.OpenWhisk.UnicodeTests.Dotnet::Apache.OpenWhisk.UnicodeTests.Dotnet.Unicode::Main")
       case _      => None
     }
   }

i can't push to your branch directly.

now the test will pass.

[codecov-io]

Codecov Report

Merging #4172 into master will increase coverage by 20.49%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #4172       +/-   ##
===========================================
+ Coverage   60.67%   81.17%   +20.49%     
===========================================
  Files         152      152               
  Lines        7291     7292        +1     
  Branches      470      472        +2     
===========================================
+ Hits         4424     5919     +1495     
+ Misses       2867     1373     -1494

Impacted Files	Coverage Δ
.../scala/org/apache/openwhisk/utils/Exceptions.scala	20% <0%> (-20%)	⬇️
...whisk/connector/kafka/KafkaProducerConnector.scala	72.5% <0%> (-15%)	⬇️
...e/openwhisk/core/containerpool/ContainerPool.scala	92.62% <0%> (+1.63%)	⬆️
.../scala/org/apache/openwhisk/core/entity/Exec.scala	85% <0%> (+1.66%)	⬆️
.../org/apache/openwhisk/core/entity/EntityPath.scala	100% <0%> (+1.88%)	⬆️
...a/org/apache/openwhisk/core/entity/Parameter.scala	95.45% <0%> (+2.27%)	⬆️
.../org/apache/openwhisk/http/PoolingRestClient.scala	90% <0%> (+3.33%)	⬆️
...hisk/core/controller/actions/SequenceActions.scala	92.1% <0%> (+3.5%)	⬆️
...tainerpool/docker/DockerClientWithFileAccess.scala	96% <0%> (+4%)	⬆️
...rg/apache/openwhisk/core/entity/ExecManifest.scala	97.87% <0%> (+4.25%)	⬆️
... and 87 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38bfc4b...876ea89. Read the comment docs.