Fix missing cz.alenkacz:gradle-scalafmt build error. #5505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Version 1.5.0 seems to have a broken pom file (see https://plugins.gradle.org/m2/gradle/plugin/cz/alenkacz/gradle-scalafmt/1.5.0/gradle-scalafmt-1.5.0.pom). Therefore the loading does not work. The 1.5.1 (https://plugins.gradle.org/m2/gradle/plugin/cz/alenkacz/gradle-scalafmt/1.5.1/gradle-scalafmt-1.5.1.pom) looks ok and can be loaded.
Move gradle scalafmt plugin from using legacy gradle import to dsl import. This should automatically adjust when the gradle plugin repository is moved. The legacy approach was a fixed location and failed when it is moved for some reason.
- The gradle dsl plugin application actually does not allow variables for the plugin version. The variable is therefore removed to avoid confusion.
|
Some more changes are required, I will update this PR as soon as I have a fix for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing cz.alenkacz:gradle-scalafmt build error.
Description
The 'cz.alenkacz:gradle-scalafmt' module could not be found anymore. Had to change the name to 'gradle.plugin.cz.alenkacz:gradle-scalafmt' and update the version to 1.5.1 since version 1.5.0 seems to have an invalid pom file (see https://plugins.gradle.org/m2/gradle/plugin/cz/alenkacz/gradle-scalafmt/1.5.0/gradle-scalafmt-1.5.0.pom) and refused to function. The version 1.5.1 seem to work fine (see https://plugins.gradle.org/m2/gradle/plugin/cz/alenkacz/gradle-scalafmt/1.5.1/gradle-scalafmt-1.5.1.pom).
Related issue and scope
My changes affect the following components
Types of changes
Checklist: