-
Notifications
You must be signed in to change notification settings - Fork 485
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
### What changes were proposed in this pull request? The java project depends on several json libraries. Replacing jackson/jettison with Gson ``` use jackson-core in orc-benchmarks-core org.apache.orc.bench.core.convert.json.JsonWriter use jettison in tools org.apache.orc.tools.KeyTool org.apache.orc.tools.JsonFileDump org.apache.orc.tools.PrintData ``` gson vs. jettison has some inconsistent 1. the scope of character escaping is inconsistent; jettison escapes '/' gson does not modify 2. Inconsistent floating point writing; jettison removes trailing zeros and decimal points where possible. gson leaves it as is. 3. prettyPrint; jettison's prettyPrint is faulty, '[' and '{' are often linked together without a line break. gson prettyPrint is fine. These three behaviours are not forward compatible in this pr. I don't think prettyPrint needs to be made compatible. The other two I would like to hear your opinion on. ### Why are the changes needed? Reduce dependencies and use a unified json lib. ### How was this patch tested? Pass the CIs.
- Loading branch information
1 parent
daa57f8
commit 2690bd3
Showing
9 changed files
with
821 additions
and
838 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.