ORC-1146: Float category missing check if the statistic sum is a finite value #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @guiyanakuang . This will be merged with your authorship after passing CIs. |
…te value ### What changes were proposed in this pull request? This pr is aimed at checking whether the float category statistic sum has a finite value. ### Why are the changes needed? When the orc float category is written with NaN, pushing down is not supported. ### How was this patch tested? Added unit test. Closes #1077 Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 93a3505) Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 9a56fa5) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr is aimed at checking whether the float category statistic sum has a finite value.
Why are the changes needed?
When the orc float category is written with NaN, pushing down is not supported.
How was this patch tested?
Added unit test.