ORC-951: Add since tag to org.apache.orc.Reader interface
#864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @omalley , @pgaref , @williamhyun |
williamhyun
reviewed
Aug 15, 2021
| @@ -144,23 +160,27 @@ | |||
| * Get the file tail (footer + postscript) | |||
There was a problem hiding this comment.
Could you add the tag to getWriterVersion? And please check the other functions once more.
williamhyun
reviewed
Aug 16, 2021
| @@ -220,6 +243,7 @@ public Options(Configuration conf) { | |||
| * Set the list of columns to read. | |||
There was a problem hiding this comment.
Could you also add the tags to the Options class and its constructors?
|
Could you review this once more please, @williamhyun ? |
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 16, 2021
### What changes were proposed in this pull request? This PR aims to add `since` tag to `org.apache.orc.Reader` interface. - The APIs added by ORC-1 is marked as `1.1.0` according to the JIRA release version. - The followings are the added versions. - 1.1.0, 1.2.0, 1.3.0, 1.5.0, 1.5.3, 1.5.9, 1.5.11, 1.6.0, 1.7.0 ### Why are the changes needed? To help ORC developers to check the API availability easily by improving code and Javadoc. ### How was this patch tested? Manual. (cherry picked from commit 5778caa) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add
sincetag toorg.apache.orc.Readerinterface.1.1.0according to the JIRA release version.Why are the changes needed?
To help ORC developers to check the API availability easily by improving code and Javadoc.
How was this patch tested?
Manual.