ORC-1017: Add sizes tool to determine and display the sizes of each column in a set of files. #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olumn in a set of files.
getting nailed on each patch when CI tests it patch.
|
Let me take a look the CI failure. |
|
I re-triggered the GitHub Action . |
dongjoon-hyun
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
+1, LGTM. Thank you, @omalley .
I reviewed and manually tested.
|
Since this is mostly |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 16, 2021
…olumn in a set of files. (#925) ### What changes were proposed in this pull request? This patch adds a new tool that accounts for the total size of a set of ORC files. For files written by >= ORC 1.5, you'll get a column breakdown of the file. There are some virtual columns that are included: - _index the indexes that are used for skipping inside the stripe - _data the data in files written prior to ORC 1.5 - _stripe_footer the stripe metadata - _file_footer the file metadata - _padding padding added to align stripes to HDFS block boundaries I also added a new method on TypeDescription that gets the full field name, which is the inverse of findSubtype. ### Why are the changes needed? The tool helps diagnose the compression of a set of files. ### How was this patch tested? I added a test of the new TypeDescription.getFullFieldName. I ran the tool over some of the examples and some multiple-terabyte directories of production ORC files. (cherry picked from commit be0762b) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch adds a new tool that accounts for the total size of a set of ORC files. For files written by >= ORC 1.5, you'll get a column breakdown of the file. There are some virtual columns that are included:
I also added a new method on TypeDescription that gets the full field name, which is the inverse of findSubtype.
Why are the changes needed?
The tool helps diagnose the compression of a set of files.
How was this patch tested?
I added a test of the new TypeDescription.getFullFieldName. I ran the tool over some of the examples and some multiple-terabyte directories of production ORC files.