HDDS-5045. Add rclone package for robot test #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
requested changes
Dec 13, 2024
Dockerfile
Outdated
| @@ -58,6 +58,11 @@ RUN sudo python3 -m pip install --upgrade pip | |||
|
|
|||
| COPY --from=go /go/bin/csc /usr/bin/csc | |||
|
|
|||
| RUN dnf install -y unzip \ | |||
| && curl https://rclone.org/install.sh | sudo bash \ | |||
There was a problem hiding this comment.
I'd rather re-implement download and extraction, instead of relying on a remote script that needs to be run as root.
Checksums are also available, see https://rclone.org/release_signing/
There was a problem hiding this comment.
I am now using the latest rpm packages available from https://downloads.rclone.org/?sort=time&order=desc.
This helps to test with newer rclone packages as they are released.
Is this approach ok or is the preferred approach still to pin the package version and verify the checksums before using them? I can update the changes to use this approach if it is preferred.
adoroszlai
approved these changes
Dec 13, 2024
adoroszlai
pushed a commit
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds the rclone tool needed for robot tests
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5045
Please replace this section with the link to the Apache JIRA)
How was this patch tested?
CI: https://github.com/ptlrs/ozone-docker-runner/actions/runs/12306659392
Manually built and ran the dev image