Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rest] Refactor RESTTokenFileIO to cache FileIO in static cache #4965

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

JingsongLi
Copy link
Contributor

@JingsongLi JingsongLi commented Jan 20, 2025

Purpose

This PR do below refactors to make REST data token simpler:

  1. Remove Catalog.fileIO(Path path), REST Catalog just create object table FileIO from client options.
  2. RESTTokenFileIO cache FileIOs in its static cache.
  3. Introduce FileIO.close() to close resources for FileIO.

This PR still lack TODO:

  1. TODO remove Catalog.fileIO, this is not work for data token in RESTCatalog.

Tests

API and Format

Documentation

@jerry-024
Copy link
Contributor

LGTM

@JingsongLi JingsongLi merged commit 00992c5 into apache:master Jan 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants