Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-java-formatter to 0.8.0 #723

Closed
wants to merge 3 commits into from

Conversation

scala-steward-asf[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates com.lightbend.sbt:sbt-java-formatter from 0.7.0 to 0.8.0

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

πŸ” Files still referring to the old version number

The following files still refer to the old version number (0.7.0).
You might want to review and update them manually.

project/Dependencies.scala
βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.lightbend.sbt", artifactId = "sbt-java-formatter" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.lightbend.sbt", artifactId = "sbt-java-formatter" }
}]
labels: sbt-plugin-update, early-semver-major, semver-spec-minor, old-version-remains, commit-count:n:3

@He-Pin
Copy link
Member

He-Pin commented Oct 16, 2023

Let me look into this

@mdedetrich
Copy link
Contributor

Let me look into this

@He-Pin There is already an open PR on this (see #593), there is an issue that the newer java formatter generates a different ordering of imports which actually changes the semantic meaning of the program causing it to fail to compile.

@He-Pin
Copy link
Member

He-Pin commented Oct 16, 2023

@mdedetrich leave it to youπŸ˜€

@mdedetrich
Copy link
Contributor

@mdedetrich leave it to youπŸ˜€

@He-Pin Well I actually got stuck because I couldn't figure out a way to configure the formatter to not re-order the imports so feel free to look into it!

@He-Pin He-Pin closed this Oct 21, 2023
@He-Pin He-Pin deleted the update/sbt-java-formatter-0.8.0 branch October 21, 2023 12:29
@He-Pin He-Pin restored the update/sbt-java-formatter-0.8.0 branch October 22, 2023 06:01
@He-Pin He-Pin reopened this Oct 22, 2023
@He-Pin He-Pin closed this Oct 23, 2023
@He-Pin He-Pin deleted the update/sbt-java-formatter-0.8.0 branch October 23, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants