-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHOENIX-7407 Remove deprecated datasource V1 code from spark2 and spark3 connector #145
base: master
Are you sure you want to change the base?
Conversation
|
I added tests for datasource v1 when I've been working on PHOENIX-6783 because there has been no tests before that. |
I added steps in github action workflow to generate test reports. The steps has failed with error "Error: HttpError: Resource not accessible by integration". |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
I have not forgotten about this, but I need to take care of some higher priority stuff first. |
I got some free time this weekend so I wanted to test something. Please do not mind about future pushes, I will post a message when I finish updates. I will create a new class with kept and added tests for V1 and helper methods then remove old class to make review easier. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Removed datasource V1 classes.
Since "org.apache.phoenix.spark" uses datasource V2 implementation there is no need to keep all tests in
PhoenixSparkDatasourceV1IT
. I only kept necessary tests because others are duplication of the ones inPhoenixSparkIT
.I added addtional steps in github action to generates tests reports details.