Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHOENIX-7308 Remove duplicate declarations of hbase-endpoint d… #146

Merged
merged 1 commit into from
Oct 15, 2024
Merged

PHOENIX-7308 Remove duplicate declarations of hbase-endpoint d… #146

merged 1 commit into from
Oct 15, 2024

Conversation

anchal246
Copy link
Contributor

…ependency in pom.xml of module phoenix5-hive-shaded

@stoty
Copy link
Contributor

stoty commented Oct 15, 2024

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 5m 22s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 ❌ mvninstall 0m 13s root in master failed.
-1 ❌ compile 6m 50s phoenix5-hive-shaded in master failed.
-1 ❌ javadoc 0m 8s phoenix5-hive-shaded in master failed.
_ Patch Compile Tests _
-1 ❌ mvninstall 0m 7s root in the patch failed.
-1 ❌ compile 0m 8s phoenix5-hive-shaded in the patch failed.
-1 ❌ javac 0m 8s phoenix5-hive-shaded in the patch failed.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
-1 ❌ javadoc 0m 8s phoenix5-hive-shaded in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 10s phoenix5-hive-shaded in the patch failed.
+1 💚 asflicense 0m 17s The patch does not generate ASF License warnings.
13m 40s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #146
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux 8f91ef8e3afd 5.15.0-122-generic #132-Ubuntu SMP Thu Aug 29 13:45:52 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 8adb127
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/1/artifact/yetus-general-check/output/branch-compile-phoenix5-hive-shaded.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-hive-shaded.txt
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/1/artifact/yetus-general-check/output/patch-compile-phoenix5-hive-shaded.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/1/artifact/yetus-general-check/output/patch-compile-phoenix5-hive-shaded.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-hive-shaded.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/1/artifact/yetus-general-check/output/patch-unit-phoenix5-hive-shaded.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/1/testReport/
Max. process+thread count 52 (vs. ulimit of 30000)
modules C: phoenix5-hive-shaded U: phoenix5-hive-shaded
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

szucsvillo
szucsvillo suggested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@szucsvillo szucsvillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the dependency is still duplicated in several other modules. It would be great to remove those duplicates as well for consistency.
Also, don't forget to include the JIRA ticket number in the commit message. Thanks!

@anchal246 anchal246 changed the title [phoenix-connectors]Remove duplicate declarations of hbase-endpoint d… PHOENIX-7308 Remove duplicate declarations of hbase-endpoint d… Oct 15, 2024
@anchal246
Copy link
Contributor Author

It looks like the dependency is still duplicated in several other modules. It would be great to remove those duplicates as well for consistency. Also, don't forget to include the JIRA ticket number in the commit message. Thanks!

Thanks for bringing this to my attention . I've updated the pr.

@stoty
Copy link
Contributor

stoty commented Oct 15, 2024

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 11s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 15m 34s Maven dependency ordering for branch
-1 ❌ mvninstall 0m 9s root in master failed.
-1 ❌ compile 0m 12s phoenix5-hive4-shaded in master failed.
-1 ❌ compile 0m 10s phoenix5-hive-shaded in master failed.
-1 ❌ compile 0m 11s phoenix5-spark3-shaded in master failed.
-1 ❌ compile 0m 9s phoenix5-spark-shaded in master failed.
-1 ❌ javadoc 0m 8s phoenix5-hive4-shaded in master failed.
-1 ❌ javadoc 0m 8s phoenix5-hive-shaded in master failed.
-1 ❌ javadoc 0m 7s phoenix5-spark3-shaded in master failed.
-1 ❌ javadoc 0m 7s phoenix5-spark-shaded in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 7s root in the patch failed.
-1 ❌ compile 0m 8s phoenix5-hive4-shaded in the patch failed.
-1 ❌ compile 0m 8s phoenix5-hive-shaded in the patch failed.
-1 ❌ compile 0m 7s phoenix5-spark3-shaded in the patch failed.
-1 ❌ compile 0m 8s phoenix5-spark-shaded in the patch failed.
-1 ❌ javac 0m 8s phoenix5-hive4-shaded in the patch failed.
-1 ❌ javac 0m 8s phoenix5-hive-shaded in the patch failed.
-1 ❌ javac 0m 7s phoenix5-spark3-shaded in the patch failed.
-1 ❌ javac 0m 8s phoenix5-spark-shaded in the patch failed.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 6s The patch has no ill-formed XML file.
-1 ❌ javadoc 0m 8s phoenix5-hive4-shaded in the patch failed.
-1 ❌ javadoc 0m 8s phoenix5-hive-shaded in the patch failed.
-1 ❌ javadoc 0m 7s phoenix5-spark3-shaded in the patch failed.
-1 ❌ javadoc 0m 8s phoenix5-spark-shaded in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 8s phoenix5-hive4-shaded in the patch failed.
-1 ❌ unit 0m 8s phoenix5-hive-shaded in the patch failed.
-1 ❌ unit 0m 7s phoenix5-spark3-shaded in the patch failed.
-1 ❌ unit 0m 8s phoenix5-spark-shaded in the patch failed.
+1 💚 asflicense 0m 38s The patch does not generate ASF License warnings.
20m 14s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #146
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux c1e3fc3f4d2f 5.15.0-122-generic #132-Ubuntu SMP Thu Aug 29 13:45:52 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 8adb127
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/branch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/branch-compile-phoenix5-hive4-shaded.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/branch-compile-phoenix5-hive-shaded.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/branch-compile-phoenix5-spark3-shaded.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/branch-compile-phoenix5-spark-shaded.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/branch-javadoc-phoenix5-hive4-shaded.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/branch-javadoc-phoenix5-hive-shaded.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3-shaded.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark-shaded.txt
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/patch-compile-phoenix5-hive4-shaded.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/patch-compile-phoenix5-hive-shaded.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3-shaded.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/patch-compile-phoenix5-spark-shaded.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/patch-compile-phoenix5-hive4-shaded.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/patch-compile-phoenix5-hive-shaded.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3-shaded.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/patch-compile-phoenix5-spark-shaded.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/patch-javadoc-phoenix5-hive4-shaded.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/patch-javadoc-phoenix5-hive-shaded.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3-shaded.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark-shaded.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/patch-unit-phoenix5-hive4-shaded.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/patch-unit-phoenix5-hive-shaded.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/patch-unit-phoenix5-spark3-shaded.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/artifact/yetus-general-check/output/patch-unit-phoenix5-spark-shaded.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/testReport/
Max. process+thread count 52 (vs. ulimit of 30000)
modules C: phoenix5-hive4-shaded phoenix5-hive-shaded phoenix5-spark3-shaded phoenix5-spark-shaded U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-146/2/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty
stoty approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@stoty stoty merged commit b29e6a5 into apache:master Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoty stoty stoty approved these changes

@szucsvillo szucsvillo szucsvillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anchal246 @stoty @szucsvillo