PHOENIX-6836: Enable code coverage reporting to SonarQube in Phoenix-Queryserver #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardantal
reviewed
Dec 5, 2022
| <sonar.dynamicAnalysis>reuseReports</sonar.dynamicAnalysis> | ||
| <sonar.surefire.reportsPath>${project.build.directory}/surefire-reports</sonar.surefire.reportsPath> | ||
| <sonar.coverage.jacoco.xmlReportPaths> | ||
| ${project.build.directory}/site/jacoco/jacoco.xml |
There was a problem hiding this comment.
Why don't we have phoenix-queryserver-assembly here like for the phoenix main repo?
There was a problem hiding this comment.
If I do it like in the phoenix component and aggregate the coverage in the assembly module then the phoenix-queryserver-orchestrator module is not included in the coverage however I tried to modified the configuration of the jacoco and sonar profiles.
| THREADS=1 | ||
| fi | ||
|
|
||
| mvn -B -e -f "$MAIN_POM" clean verify -Pcodecoverage -fn -Dmaven.javadoc.skip=true -DskipShade -T "$THREADS" |
There was a problem hiding this comment.
Shouldn't we have coverage profile here?
There was a problem hiding this comment.
Good point regarding the new profile I have added but never used :)
I added the sonar analysis to the original codecoverage profile so my coverage profile is not necessary, looks like I forgot to remove it.
horvathdora
force-pushed
the
PHOENIX-6836
branch
from
944c5ea to
f031cd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.