Skip to content

Commit

Permalink
Revert access specifier for _dataDir and _propertyStore. The getter c…
Browse files Browse the repository at this point in the history
…an be used instead
  • Loading branch information
Aman Khanchandani committed Jun 28, 2024
1 parent c786297 commit 7bdcf16
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ public void init(PinotConfiguration pinotConfiguration)
_adminApp = createControllerAdminApp();
// Do not use this before the invocation of {@link PinotHelixResourceManager::start()}, which happens in {@link
// ControllerStarter::start()}
_helixResourceManager = createPinotHelixResourceManager();
_helixResourceManager = createHelixResourceManager();
// This executor service is used to do async tasks from multiget util or table rebalancing.
_executorService =
Executors.newCachedThreadPool(new ThreadFactoryBuilder().setNameFormat("async-task-thread-%d").build());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -215,15 +215,15 @@ private enum LineageUpdateType {

private final String _helixZkURL;
private final String _helixClusterName;
protected final String _dataDir;
private final String _dataDir;
private final boolean _isSingleTenantCluster;
private final boolean _enableBatchMessageMode;
private final int _deletedSegmentsRetentionInDays;
private final boolean _enableTieredSegmentAssignment;

private HelixManager _helixZkManager;
private HelixAdmin _helixAdmin;
protected ZkHelixPropertyStore<ZNRecord> _propertyStore;
private ZkHelixPropertyStore<ZNRecord> _propertyStore;
private HelixDataAccessor _helixDataAccessor;
private Builder _keyBuilder;
private ControllerMetrics _controllerMetrics;
Expand Down

0 comments on commit 7bdcf16

Please sign in to comment.