Add extract(quarter/dow/doy) support #11388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 19, 2023 18:49
saurabhd336
changed the title
xiangfu0
approved these changes
Aug 19, 2023
There was a problem hiding this comment.
lgtm, please add the test in org.apache.pinot.integration.tests.custom.TimestampTest.
See: https://github.com/apache/pinot/pull/11350/files#diff-fdd6baeeb7053985a767ec75adac332e0eb890f54db83e6fe2e4f055f014a8e7R127
Codecov Report
@@ Coverage Diff @@
## master #11388 +/- ##
============================================
+ Coverage 61.42% 61.44% +0.01%
- Complexity 6512 6514 +2
============================================
Files 2234 2234
Lines 120158 120173 +15
Branches 18239 18240 +1
============================================
+ Hits 73811 73835 +24
+ Misses 40918 40909 -9
Partials 5429 5429
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
approved these changes
Aug 19, 2023
...rc/main/java/org/apache/pinot/core/operator/transform/function/ExtractTransformFunction.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/pinot/core/operator/transform/function/ExtractTransformFunction.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fails on V2 with
because calcite rewriter implicitly converts it to a extract query