#5695 Increasing test coverage pinot-common

[aditya0811]

5695

(*) Other labels to consider:

• testing

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.78%. Comparing base (59551e4) to head (c72e897).
Report is 14 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #12294      +/-   ##
============================================
+ Coverage     61.75%   61.78%   +0.03%     
  Complexity      207      207              
============================================
  Files          2436     2436              
  Lines        133233   133237       +4     
  Branches      20636    20639       +3     
============================================
+ Hits          82274    82319      +45     
+ Misses        44911    44859      -52     
- Partials       6048     6059      +11     

Flag	Coverage Δ
custom-integration1	<0.01% <ø> (ø)
integration	<0.01% <ø> (ø)
integration1	<0.01% <ø> (ø)
integration2	0.00% <ø> (ø)
java-11	61.74% <ø> (+0.03%)	⬆️
java-21	61.65% <ø> (+0.02%)	⬆️
skip-bytebuffers-false	61.76% <ø> (+0.02%)	⬆️
skip-bytebuffers-true	61.62% <ø> (+33.90%)	⬆️
temurin	61.78% <ø> (+0.03%)	⬆️
unittests	61.77% <ø> (+0.03%)	⬆️
unittests1	46.93% <ø> (+0.04%)	⬆️
unittests2	27.72% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Jackie-Jiang]

Can you please take a look at the linter failure?
It would be very helpful if you can also include how many missing lines are covered within this new test

[gortiz]

It seems there are some compilation issues. Can you fix them?

[aditya0811]

It seems there are some compilation issues. Can you fix them?

updated with latest code, constructor changed

[aditya0811]

Can you please take a look at the linter failure? It would be very helpful if you can also include how many missing lines are covered within this new test

Fixed. covers 79 missing lines, was not able to set up UT for L77.

[gortiz]

Merged, thanks for this contribution and my personal apologies for taking so much time to merge it.

[aditya0811]

Merged, thanks for this contribution and my personal apologies for taking so much time to merge it.

no worries, happy to contribute.