Fix file handle leaks in Pinot Driver (apache#12263) #12356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12356 +/- ##
============================================
+ Coverage 61.66% 61.83% +0.16%
+ Complexity 1150 207 -943
============================================
Files 2426 2426
Lines 132776 132790 +14
Branches 20541 20543 +2
============================================
+ Hits 81874 82106 +232
+ Misses 44884 44653 -231
- Partials 6018 6031 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PinotDriver.connect() leaks the PinotClientTransport and PinotControllerTransport if an exception is thrown.
I added unit tests to test both a bad URL and a good URL that doesn't connect.
I performed manual tests of the closeResourceSafely method as it is a small private method. I performed the test by debugging the code through that method and verify the two resource do indeed close if there is an exception thrown.