Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in logging in UpsertCompaction task #12419

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

tibrewalpratik17
Copy link
Contributor

label:
bugfix

At present, the log message comes like:

Unable to get validDocIdsMetadata from all servers. Expected: 0, Actual: 1

This is wrong due to following reasons:

  • In the loop, we are iterating over the responses of all server-requests, and incrementing segmentCount by 1. Should be serverCount.
  • We are using the above wrong segmentCount value with expected segmentNames passed value.

Adding both logs for unequal segment count and unequal server count to improve debuggability.
Also renaming all logs to have "validDocIds" for easier debugging. At present, some logs had "valid doc ids" and some had "validDocIds".

cc @snleee

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (e1e22bd) 61.74% compared to head (9d13428) 61.76%.
Report is 11 commits behind head on master.

Files Patch % Lines
...t/controller/util/ServerSegmentMetadataReader.java 0.00% 10 Missing ⚠️
...l/indexsegment/immutable/ImmutableSegmentImpl.java 28.57% 5 Missing ⚠️
...oller/api/resources/PinotTableRestletResource.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12419      +/-   ##
============================================
+ Coverage     61.74%   61.76%   +0.02%     
  Complexity      207      207              
============================================
  Files          2436     2436              
  Lines        133089   133111      +22     
  Branches      20615    20618       +3     
============================================
+ Hits          82172    82222      +50     
+ Misses        44878    44853      -25     
+ Partials       6039     6036       -3     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.69% <11.11%> (+<0.01%) ⬆️
java-21 61.65% <11.11%> (+0.02%) ⬆️
skip-bytebuffers-false 61.74% <11.11%> (+0.01%) ⬆️
skip-bytebuffers-true 61.60% <11.11%> (+0.01%) ⬆️
temurin 61.76% <11.11%> (+0.02%) ⬆️
unittests 61.76% <11.11%> (+0.02%) ⬆️
unittests1 46.91% <0.00%> (+0.02%) ⬆️
unittests2 27.73% <11.11%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@snleee snleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for addressing this!

@ankitsultana ankitsultana merged commit 20f3fc6 into apache:master Feb 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants