Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make http listener ssl config swappable #12455

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

zhtaoxiang
Copy link
Contributor

This is a follow up of #12277 (that PR makes tls keystore/truststore swappable) and #12325 (that PR makes query client and server auto reload tls keystore/truststore when they are local files)

This PR enables auto reloading tls keystore/truststore for http servers created using org.glassfish.grizzly.http.server.HttpServer

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (8c395ff) 61.73% compared to head (93e024e) 27.73%.
Report is 4 commits behind head on master.

Files Patch % Lines
...n/java/org/apache/pinot/common/utils/TlsUtils.java 0.00% 7 Missing ⚠️
...org/apache/pinot/core/util/ListenerConfigUtil.java 0.00% 2 Missing ⚠️
...pache/pinot/common/utils/grpc/GrpcQueryClient.java 0.00% 1 Missing ⚠️
...che/pinot/core/transport/grpc/GrpcQueryServer.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12455       +/-   ##
=============================================
- Coverage     61.73%   27.73%   -34.01%     
  Complexity      207      207               
=============================================
  Files          2436     2436               
  Lines        133173   133178        +5     
  Branches      20631    20628        -3     
=============================================
- Hits          82220    36935    -45285     
- Misses        44907    93433    +48526     
+ Partials       6046     2810     -3236     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 27.72% <0.00%> (-33.97%) ⬇️
java-21 27.73% <0.00%> (-33.89%) ⬇️
skip-bytebuffers-false 27.73% <0.00%> (-33.98%) ⬇️
skip-bytebuffers-true 27.73% <0.00%> (-33.86%) ⬇️
temurin 27.73% <0.00%> (-34.01%) ⬇️
unittests 27.72% <0.00%> (-34.01%) ⬇️
unittests1 ?
unittests2 27.72% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 self-requested a review February 21, 2024 03:22
@xiangfu0 xiangfu0 merged commit 99e2908 into apache:master Feb 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants