Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling avroParquet to read Int96 as bytes #12484

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

swaminathanmanish
Copy link
Contributor

@swaminathanmanish swaminathanmanish commented Feb 23, 2024

Whats in the PR:
Enabling avro parquet reader to read int96 types.

Parquet PR that introduced this option.

Why this is needed:
We need avro reader to workaround int96 issues in input/source parquet data.

java.lang.IllegalArgumentException: INT96 is deprecated. As interim enable READ_INT96_AS_FIXED flag to read as byte array.

	at org.apache.parquet.avro.AvroSchemaConverter$1.convertINT96(AvroSchemaConverter.java:331)
	at org.apache.parquet.avro.AvroSchemaConverter$1.convertINT96(AvroSchemaConverter.java:313)
	at org.apache.parquet.schema.PrimitiveType$PrimitiveTypeName$7.convert(PrimitiveType.java:341)
	at org.apache.parquet.avro.AvroSchemaConverter.convertField(AvroSchemaConverter.java:312)

@swaminathanmanish
Copy link
Contributor Author

@snleee - Could you take a look

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.71%. Comparing base (8434158) to head (8239c83).
Report is 983 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12484      +/-   ##
============================================
- Coverage     61.74%   61.71%   -0.04%     
+ Complexity     1142      207     -935     
============================================
  Files          2425     2436      +11     
  Lines        132715   133220     +505     
  Branches      20532    20635     +103     
============================================
+ Hits          81942    82212     +270     
- Misses        44759    44962     +203     
- Partials       6014     6046      +32     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 61.67% <100.00%> (+0.01%) ⬆️
java-21 61.59% <100.00%> (-0.03%) ⬇️
skip-bytebuffers-false 61.70% <100.00%> (-0.03%) ⬇️
skip-bytebuffers-true 61.57% <100.00%> (+0.01%) ⬆️
temurin 61.71% <100.00%> (-0.04%) ⬇️
unittests 61.70% <100.00%> (-0.04%) ⬇️
unittests1 46.85% <ø> (-0.03%) ⬇️
unittests2 27.72% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swaminathanmanish swaminathanmanish changed the title (WIP) Enabling avroParquet to read Int96 as bytes Enabling avroParquet to read Int96 as bytes Feb 23, 2024
@Jackie-Jiang Jackie-Jiang merged commit 55cecc1 into apache:master Feb 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants