-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLP as a compressionCodec #12504
Merged
Merged
CLP as a compressionCodec #12504
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
0e31639
Enricher interface
c9fd201
Support in realtime ingestion
0c7f840
Merge branch 'master' of github.com:apache/pinot into recordEnricher
d2b2328
Fix offline segment builder
262605a
Add enricher to mapper
fdcdbb7
Add columnsToExtract config
371877e
Merge branch 'master' of github.com:apache/pinot into recordEnricher
b4e2083
Complete enricher pipeline usage
f57eb3d
Add CLP as a compression type
c408cde
Finish the flow to add CLP index
9797791
Add reader
c80f6e0
Complete the reader
792c5a5
Lint fix
abb3f64
Avoid full file copy
acffbb7
Add mutable CLP index
ac69d83
Fix NPe
41a758d
Merge branch 'master' of github.com:apache/pinot into logDataType
9f3a4d6
Fix for null values
71457e9
Fix class name
345b57c
Merge branch 'master' of github.com:apache/pinot into logDataType
86823d3
Add context handlint
b87a5b1
Enrichment configs
e5471b6
Refactoring the upsert compaction related code (#12275)
94b404b
Merge branch 'master' of github.com:apache/pinot into logDataType
835559e
Merge branch 'master' of github.com:apache/pinot into logDataType
9683def
Merge branch 'master' of github.com:apache/pinot into logDataType
7c16c92
Add mutable index tests
8ca1650
Lint
0ad8a6d
Merge branch 'master' of github.com:apache/pinot into logDataType
965f7c2
Fix tests
e474bb2
Remove chunkCompressionType
951df7b
Add validations
fcfac6b
Add ITs
c81fa0d
Lint + misc
013ebc1
Lint
342ce5c
Fix context close
e2e5180
Add recordByteRanges support
78532fe
Review comments
0dd5e72
Merge branch 'master' of github.com:apache/pinot into logDataType
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
150 changes: 150 additions & 0 deletions
150
.../src/test/java/org/apache/pinot/integration/tests/CLPEncodingRealtimeIntegrationTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,150 @@ | ||
/** | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package org.apache.pinot.integration.tests; | ||
|
||
import java.io.File; | ||
import java.util.ArrayList; | ||
import java.util.Collections; | ||
import java.util.List; | ||
import javax.annotation.Nullable; | ||
import org.apache.pinot.spi.config.table.FieldConfig; | ||
import org.apache.pinot.spi.config.table.TableConfig; | ||
import org.apache.pinot.spi.config.table.ingestion.IngestionConfig; | ||
import org.apache.pinot.spi.config.table.ingestion.TransformConfig; | ||
import org.apache.pinot.spi.data.Schema; | ||
import org.apache.pinot.util.TestUtils; | ||
import org.testng.Assert; | ||
import org.testng.annotations.BeforeClass; | ||
import org.testng.annotations.Test; | ||
|
||
|
||
public class CLPEncodingRealtimeIntegrationTest extends BaseClusterIntegrationTestSet { | ||
private List<File> _avroFiles; | ||
|
||
@BeforeClass | ||
public void setUp() | ||
throws Exception { | ||
TestUtils.ensureDirectoriesExistAndEmpty(_tempDir, _segmentDir, _tarDir); | ||
_avroFiles = unpackAvroData(_tempDir); | ||
|
||
// Start the Pinot cluster | ||
startZk(); | ||
// Start a customized controller with more frequent realtime segment validation | ||
startController(); | ||
startBroker(); | ||
startServers(1); | ||
|
||
startKafka(); | ||
pushAvroIntoKafka(_avroFiles); | ||
|
||
Schema schema = createSchema(); | ||
addSchema(schema); | ||
TableConfig tableConfig = createRealtimeTableConfig(_avroFiles.get(0)); | ||
addTableConfig(tableConfig); | ||
|
||
waitForAllDocsLoaded(600_000L); | ||
} | ||
|
||
@Nullable | ||
@Override | ||
protected List<String> getInvertedIndexColumns() { | ||
return null; | ||
} | ||
|
||
@Nullable | ||
@Override | ||
protected List<String> getRangeIndexColumns() { | ||
return null; | ||
} | ||
|
||
@Nullable | ||
@Override | ||
protected List<String> getBloomFilterColumns() { | ||
return null; | ||
} | ||
|
||
@Nullable | ||
@Override | ||
protected String getSortedColumn() { | ||
return null; | ||
} | ||
|
||
@Override | ||
protected List<String> getNoDictionaryColumns() { | ||
return Collections.singletonList("logLine"); | ||
} | ||
|
||
@Test | ||
public void testValues() | ||
throws Exception { | ||
Assert.assertEquals(getPinotConnection().execute( | ||
"SELECT count(*) FROM " + getTableName() + " WHERE REGEXP_LIKE(logLine, '.*executor.*')").getResultSet(0) | ||
.getLong(0), 53); | ||
} | ||
|
||
protected int getRealtimeSegmentFlushSize() { | ||
return 30; | ||
} | ||
|
||
@Override | ||
protected long getCountStarResult() { | ||
return 100; | ||
} | ||
|
||
@Override | ||
protected String getTableName() { | ||
return "clpEncodingIT"; | ||
} | ||
|
||
@Override | ||
protected String getAvroTarFileName() { | ||
return "clpEncodingITData.tar.gz"; | ||
} | ||
|
||
@Override | ||
protected String getSchemaFileName() { | ||
return "clpEncodingRealtimeIntegrationTestSchema.schema"; | ||
} | ||
|
||
@Override | ||
protected String getTimeColumnName() { | ||
return "timestampInEpoch"; | ||
} | ||
|
||
@Override | ||
protected List<FieldConfig> getFieldConfigs() { | ||
List<FieldConfig> fieldConfigs = new ArrayList<>(); | ||
fieldConfigs.add( | ||
new FieldConfig("logLine", FieldConfig.EncodingType.RAW, null, null, FieldConfig.CompressionCodec.CLP, null, | ||
null, null, null)); | ||
|
||
return fieldConfigs; | ||
} | ||
|
||
@Override | ||
protected IngestionConfig getIngestionConfig() { | ||
List<TransformConfig> transforms = new ArrayList<>(); | ||
transforms.add(new TransformConfig("timestampInEpoch", "now()")); | ||
|
||
IngestionConfig ingestionConfig = new IngestionConfig(); | ||
ingestionConfig.setTransformConfigs(transforms); | ||
|
||
return ingestionConfig; | ||
} | ||
} |
Binary file not shown.
18 changes: 18 additions & 0 deletions
18
pinot-integration-tests/src/test/resources/clpEncodingRealtimeIntegrationTestSchema.schema
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
{ | ||
"schemaName": "clpEncodingIT", | ||
"dimensionFieldSpecs": [ | ||
{ | ||
"name": "logLine", | ||
"dataType": "STRING" | ||
} | ||
], | ||
"dateTimeFieldSpecs": [ | ||
{ | ||
"name": "timestampInEpoch", | ||
"dataType": "LONG", | ||
"notNull": false, | ||
"format": "1:MILLISECONDS:EPOCH", | ||
"granularity": "1:MILLISECONDS" | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel an integration test is a little bit overkilling here since all we want to verify is reading from the forward index. Suggest removing this one and using unit test to cover it