Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ControllerJobType from enum to string #12518

Merged

Conversation

zhtaoxiang
Copy link
Contributor

update ControllerJobType from enum to string to make it flexible to extend

@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 61.59%. Comparing base (59551e4) to head (1e607bb).
Report is 28 commits behind head on master.

Files Patch % Lines
...oller/api/resources/PinotTableRestletResource.java 0.00% 5 Missing ⚠️
...ntroller/helix/core/PinotHelixResourceManager.java 20.00% 4 Missing ⚠️
...ache/pinot/common/metadata/ZKMetadataProvider.java 0.00% 1 Missing ⚠️
...mmon/metadata/controllerjob/ControllerJobType.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12518      +/-   ##
============================================
- Coverage     61.75%   61.59%   -0.16%     
  Complexity      207      207              
============================================
  Files          2436     2450      +14     
  Lines        133233   133500     +267     
  Branches      20636    20684      +48     
============================================
- Hits          82274    82226      -48     
- Misses        44911    45176     +265     
- Partials       6048     6098      +50     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 27.71% <21.42%> (-34.00%) ⬇️
java-21 34.85% <0.00%> (-26.78%) ⬇️
skip-bytebuffers-false 61.59% <21.42%> (-0.16%) ⬇️
skip-bytebuffers-true 0.00% <0.00%> (-27.73%) ⬇️
temurin 61.59% <21.42%> (-0.16%) ⬇️
unittests 61.58% <21.42%> (-0.16%) ⬇️
unittests1 46.67% <0.00%> (-0.22%) ⬇️
unittests2 27.71% <21.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 704f73d into apache:master Feb 29, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants