Bugfix. Maintain literal data type during function evaluation #12607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12607 +/- ##
============================================
- Coverage 61.75% 61.67% -0.08%
+ Complexity 207 198 -9
============================================
Files 2436 2450 +14
Lines 133233 133745 +512
Branches 20636 20744 +108
============================================
+ Hits 82274 82488 +214
- Misses 44911 45148 +237
- Partials 6048 6109 +61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
reviewed
Mar 8, 2024
...nt-local/src/main/java/org/apache/pinot/segment/local/function/InbuiltFunctionEvaluator.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
ConstantExecutionNodestores the literal value as String which creates problems while dealing with boolean literals as the execution returns a String and ends up doingSTRING.toInt(toIntas boolean has stored type as int)on a"true"value while it should be doingBOOLEAN.toIntinstead.