Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PulsarUtils to not share buffer #12671

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

Jackie-Jiang
Copy link
Contributor

Fix a bug where a static singleton buffer was shared when reading message

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 61.46%. Comparing base (59551e4) to head (cc7b30f).
Report is 144 commits behind head on master.

Files Patch % Lines
...apache/pinot/plugin/stream/pulsar/PulsarUtils.java 85.71% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12671      +/-   ##
============================================
- Coverage     61.75%   61.46%   -0.29%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2452      +16     
  Lines        133233   133840     +607     
  Branches      20636    20765     +129     
============================================
- Hits          82274    82267       -7     
- Misses        44911    45415     +504     
- Partials       6048     6158     +110     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 61.41% <85.71%> (-0.29%) ⬇️
java-21 61.33% <85.71%> (-0.29%) ⬇️
skip-bytebuffers-false 61.45% <85.71%> (-0.30%) ⬇️
skip-bytebuffers-true 61.30% <85.71%> (+33.57%) ⬆️
temurin 61.46% <85.71%> (-0.29%) ⬇️
unittests 61.46% <85.71%> (-0.29%) ⬇️
unittests1 46.36% <ø> (-0.53%) ⬇️
unittests2 27.75% <85.71%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swaminathanmanish
Copy link
Contributor

Fix a bug where a static singleton buffer was shared when reading message

Any context on how you found this problem?

@Jackie-Jiang
Copy link
Contributor Author

Fix a bug where a static singleton buffer was shared when reading message

Any context on how you found this problem?

I was planning to cleanup some real-time ingestion code, then find this by randomly reading

@Jackie-Jiang Jackie-Jiang merged commit 8c92341 into apache:master Mar 19, 2024
19 checks passed
@Jackie-Jiang Jackie-Jiang deleted the fix_pulsar_buffer_sharing branch March 19, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants