add SegmentContext to collect validDocIds bitmaps for many segments together #12694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12694 +/- ##
============================================
+ Coverage 61.75% 62.04% +0.28%
+ Complexity 207 198 -9
============================================
Files 2436 2464 +28
Lines 133233 134762 +1529
Branches 20636 20813 +177
============================================
+ Hits 82274 83607 +1333
- Misses 44911 45002 +91
- Partials 6048 6153 +105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tibrewalpratik17
approved these changes
Mar 22, 2024
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
Show resolved
Hide resolved
...main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapTableUpsertMetadataManager.java
Outdated
Show resolved
Hide resolved
klsince
force-pushed
the
validdocids_as_segment_context
branch
from
2f92034 to
080a453
Compare
Jackie-Jiang
reviewed
Apr 5, 2024
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/SegmentContext.java
Outdated
Show resolved
Hide resolved
...nt-local/src/main/java/org/apache/pinot/segment/local/upsert/TableUpsertMetadataManager.java
Outdated
Show resolved
Hide resolved
klsince
force-pushed
the
validdocids_as_segment_context
branch
from
6926891 to
a353b11
Compare
Jackie-Jiang
added
the
incompatible
Jackie-Jiang
approved these changes
Apr 8, 2024
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SegmentContext used to collect segment related context before query execution. E.g. this makes it easier to collect validDocIds for many segments together, so that we can add the support for consistent table view for upsert table easier later on.
This PR didn't change current functionalities but moved the logic of getting validDocId bitmaps upto one place, i.e.
tableDataMgr.getSegmentContexts(selectedSegments).