Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for additional data types in SegmentPreProcessorTest.java #12755

Merged

Conversation

aadilkhalifa
Copy link
Contributor

Related to #12501

Added tests for ColumnMinMax calculation in SegmentPreProcessorTest.java for all supported data types.

@aadilkhalifa
Copy link
Contributor Author

@Jackie-Jiang Can you please have a look at this?

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.55%. Comparing base (59551e4) to head (b93ca16).
Report is 211 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12755      +/-   ##
============================================
- Coverage     61.75%   61.55%   -0.20%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2462      +26     
  Lines        133233   134588    +1355     
  Branches      20636    20838     +202     
============================================
+ Hits          82274    82845     +571     
- Misses        44911    45550     +639     
- Partials       6048     6193     +145     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 0.00% <ø> (ø)
java-11 61.52% <ø> (-0.19%) ⬇️
java-21 61.42% <ø> (-0.20%) ⬇️
skip-bytebuffers-false 61.54% <ø> (-0.21%) ⬇️
skip-bytebuffers-true 61.40% <ø> (+33.67%) ⬆️
temurin 61.55% <ø> (-0.20%) ⬇️
unittests 61.55% <ø> (-0.20%) ⬇️
unittests1 46.13% <ø> (-0.76%) ⬇️
unittests2 27.95% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start!

Besides default column generation, we also want to cover:

  • Derived column generation
  • Forward index conversion/generation
  • MinMax value generation
  • Other index generation

They can be added in separate PRs

@Jackie-Jiang Jackie-Jiang merged commit e477afa into apache:master Apr 5, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants