Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Add Nullable annotation to HttpHeaders in BrokerRequestHandler #12816

Merged

Conversation

Jackie-Jiang
Copy link
Contributor

Address #12745

Copy link
Member

@jackjlli jackjlli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding the annotations!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (59551e4) to head (f2bfb82).
Report is 224 commits behind head on master.

Files Patch % Lines
...r/requesthandler/BrokerRequestHandlerDelegate.java 0.00% 5 Missing ⚠️
...roker/requesthandler/BaseBrokerRequestHandler.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12816       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%     
=============================================
  Files          2436     2387       -49     
  Lines        133233   131078     -2155     
  Branches      20636    20262      -374     
=============================================
- Hits          82274        0    -82274     
- Misses        44911   131078    +86167     
+ Partials       6048        0     -6048     
Flag Coverage Δ
custom-integration1 ?
integration 0.00% <0.00%> (-0.01%) ⬇️
integration1 ?
integration2 0.00% <0.00%> (ø)
java-11 ?
java-21 0.00% <0.00%> (-61.63%) ⬇️
skip-bytebuffers-false 0.00% <0.00%> (-61.75%) ⬇️
skip-bytebuffers-true ?
temurin 0.00% <0.00%> (-61.76%) ⬇️
unittests ?
unittests1 ?
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 650e258 into apache:master Apr 8, 2024
17 of 19 checks passed
@Jackie-Jiang Jackie-Jiang deleted the minor_database_null_handling branch April 8, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants