Enable complexType handling in SegmentProcessFramework #12942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaminathanmanish
force-pushed
the
ctransformer
branch
from
0f05ff3 to
a7c97d8
Compare
|
@klsince - Could you take a look ? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12942 +/- ##
============================================
+ Coverage 61.75% 62.22% +0.46%
+ Complexity 207 198 -9
============================================
Files 2436 2502 +66
Lines 133233 136489 +3256
Branches 20636 21123 +487
============================================
+ Hits 82274 84925 +2651
- Misses 44911 45284 +373
- Partials 6048 6280 +232
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
swaminathanmanish
changed the title
KKcorps
approved these changes
Apr 18, 2024
.../main/java/org/apache/pinot/core/segment/processing/framework/SegmentProcessorFramework.java
Outdated
Show resolved
Hide resolved
...cal/src/main/java/org/apache/pinot/segment/local/recordtransformer/CompositeTransformer.java
Outdated
Show resolved
Hide resolved
klsince
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whats in the PR:
Enabling complexType (ingestion config) handling in SegmentProcessorFramework
Why its needed:
For batch/minion based ingestion SegmentProcessorFramework is the building block which currently does not support complex type transformation. With this change, all batch ingestion tasks that use SegmentProcessorFramework, will get the ability to transform complexType.