Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ProtoSerializationUtils to handle class move #12946

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

Jackie-Jiang
Copy link
Contributor

With this change, we can handle class movement of regular classes and enums. For interface, we still need to rely on the full class name.
This can prevent the problem introduced in #12837

@Jackie-Jiang Jackie-Jiang added enhancement multi-stage Related to the multi-stage query engine labels Apr 17, 2024
@Jackie-Jiang Jackie-Jiang requested a review from xiangfu0 April 17, 2024 01:05
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 62.22%. Comparing base (59551e4) to head (c0891bd).
Report is 316 commits behind head on master.

Files Patch % Lines
...t/query/planner/serde/ProtoSerializationUtils.java 86.66% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12946      +/-   ##
============================================
+ Coverage     61.75%   62.22%   +0.47%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2503      +67     
  Lines        133233   136482    +3249     
  Branches      20636    21120     +484     
============================================
+ Hits          82274    84922    +2648     
- Misses        44911    45283     +372     
- Partials       6048     6277     +229     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.17% <86.66%> (+0.46%) ⬆️
java-21 62.08% <86.66%> (+0.46%) ⬆️
skip-bytebuffers-false 62.21% <86.66%> (+0.46%) ⬆️
skip-bytebuffers-true 34.99% <86.66%> (+7.26%) ⬆️
temurin 62.22% <86.66%> (+0.47%) ⬆️
unittests 62.21% <86.66%> (+0.47%) ⬆️
unittests1 46.69% <86.66%> (-0.20%) ⬇️
unittests2 28.01% <0.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit af2fcb7 into apache:master Apr 17, 2024
19 of 20 checks passed
@Jackie-Jiang Jackie-Jiang deleted the enhance_query_plan_ser_de branch April 17, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement multi-stage Related to the multi-stage query engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants