Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid useless byte array allocation for VarChunkV4Reader StringMV #12978

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

wirybeaver
Copy link
Contributor

@wirybeaver wirybeaver commented Apr 21, 2024

The title says it all.

Benchmarking: TBD.

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.17%. Comparing base (59551e4) to head (c5e7785).
Report is 345 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12978      +/-   ##
============================================
+ Coverage     61.75%   62.17%   +0.42%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2502      +66     
  Lines        133233   136503    +3270     
  Branches      20636    21128     +492     
============================================
+ Hits          82274    84872    +2598     
- Misses        44911    45352     +441     
- Partials       6048     6279     +231     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.09% <100.00%> (+0.38%) ⬆️
java-21 62.05% <100.00%> (+0.43%) ⬆️
skip-bytebuffers-false 62.14% <100.00%> (+0.39%) ⬆️
skip-bytebuffers-true 35.03% <0.00%> (+7.30%) ⬆️
temurin 62.17% <100.00%> (+0.42%) ⬆️
unittests 62.17% <100.00%> (+0.42%) ⬆️
unittests1 46.72% <0.00%> (-0.17%) ⬇️
unittests2 27.94% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Jackie-Jiang Jackie-Jiang merged commit 99a4180 into apache:master Apr 25, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants