Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13123 MaxLength limiting included for Json Columns #13181

Closed
wants to merge 3 commits into from

Conversation

deepthi912
Copy link
Collaborator

@deepthi912 deepthi912 commented May 19, 2024

#13123
Fix:

  1. Added code to sanitize the json column to "$SKIPPED$". The way it is in JsonIndex.
  2. Exposed Server metric for the sanitized values (numColsLimitedByMaxLength)

There seems to be duplication with the below PR:
#13103

@deepthi912 deepthi912 changed the title #13123 Add metric to check maxLength for Json Columns #13123 MaxLength checking for Json Columns May 19, 2024
@deepthi912 deepthi912 changed the title #13123 MaxLength checking for Json Columns #13123 MaxLength limiting included for Json Columns May 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (59551e4) to head (61606c8).
Report is 471 commits behind head on master.

Files Patch % Lines
...cal/recordtransformer/SanitizationTransformer.java 0.00% 38 Missing ⚠️
...a/manager/realtime/RealtimeSegmentDataManager.java 0.00% 4 Missing ⚠️
...ain/java/org/apache/pinot/spi/utils/JsonUtils.java 0.00% 4 Missing ⚠️
...a/org/apache/pinot/common/metrics/ServerMeter.java 0.00% 2 Missing ⚠️
...ent/local/recordtransformer/RecordTransformer.java 0.00% 1 Missing ⚠️
...gment/local/segment/creator/TransformPipeline.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13181       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.75%     
+ Complexity      207        6      -201     
=============================================
  Files          2436     2454       +18     
  Lines        133233   134667     +1434     
  Branches      20636    20856      +220     
=============================================
- Hits          82274        6    -82268     
- Misses        44911   134661    +89750     
+ Partials       6048        0     -6048     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 <0.01% <0.00%> (-61.71%) ⬇️
java-21 <0.01% <0.00%> (-61.63%) ⬇️
skip-bytebuffers-false <0.01% <0.00%> (-61.75%) ⬇️
skip-bytebuffers-true <0.01% <0.00%> (-27.73%) ⬇️
temurin <0.01% <0.00%> (-61.75%) ⬇️
unittests ?
unittests1 ?
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@npawar
Copy link
Contributor

npawar commented Jul 11, 2024

looks like we can close this ticket then @deepthi912 ? is there aything that's in your PR that's not covered in the one linked here?

@deepthi912
Copy link
Collaborator Author

deepthi912 commented Jul 14, 2024

@npawar #13103 covered the scenarios. So, we can close the PR and ticket looks closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants