Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle overflow for MutableOffHeapByteArrayStore buffer starting size #13215

Merged
merged 3 commits into from
Jun 8, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,9 @@ public MutableOffHeapByteArrayStore(PinotDataBufferMemoryManager memoryManager,
int numArrays, int avgArrayLen) {
_memoryManager = memoryManager;
_allocationContext = allocationContext;
_startSize = numArrays * (avgArrayLen + 4); // For each array, we store the array and its startoffset (4 bytes)
int estimatedSize =
numArrays * (avgArrayLen + 4); // For each array, we store the array and its startoffset (4 bytes)
itschrispeck marked this conversation as resolved.
Show resolved Hide resolved
_startSize = estimatedSize > 0 ? estimatedSize : Integer.MAX_VALUE;
expand(_startSize);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,14 @@ public void maxValueTest()
store.close();
}

@Test
public void startSizeOverflowTest()
throws Exception {
MutableOffHeapByteArrayStore store =
new MutableOffHeapByteArrayStore(_memoryManager, "stringColumn", 3, 1024 * 1024 * 1024);
store.close();
}

@Test
public void overflowTest()
throws Exception {
Expand Down
Loading