Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release segment mgrs more reliably #13216

Merged
merged 1 commit into from
May 24, 2024

Conversation

klsince
Copy link
Contributor

@klsince klsince commented May 23, 2024

Adjust the try-finally block a bit to release segment mgr more reliably to avoid leaking the refs of segment mgrs, which can block the segments to be released properly when it's dropped by retention mgr.

@klsince klsince added the bugfix label May 23, 2024
@klsince klsince requested a review from snleee May 23, 2024 23:02
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.17%. Comparing base (59551e4) to head (9e3390b).
Report is 490 commits behind head on master.

Files Patch % Lines
...che/pinot/server/api/resources/TablesResource.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13216      +/-   ##
============================================
+ Coverage     61.75%   62.17%   +0.42%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2533      +97     
  Lines        133233   138810    +5577     
  Branches      20636    21499     +863     
============================================
+ Hits          82274    86309    +4035     
- Misses        44911    46053    +1142     
- Partials       6048     6448     +400     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.12% <83.33%> (+0.41%) ⬆️
java-21 62.06% <83.33%> (+0.43%) ⬆️
skip-bytebuffers-false 62.15% <83.33%> (+0.40%) ⬆️
skip-bytebuffers-true 62.02% <83.33%> (+34.29%) ⬆️
temurin 62.17% <83.33%> (+0.42%) ⬆️
unittests 62.17% <83.33%> (+0.42%) ⬆️
unittests1 46.66% <ø> (-0.23%) ⬇️
unittests2 27.86% <83.33%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@snleee snleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you for quickly improving this!

@Jackie-Jiang Jackie-Jiang merged commit 1e42a67 into apache:master May 24, 2024
19 checks passed
@klsince klsince deleted the release_segment_mgrs branch May 24, 2024 16:31
gortiz pushed a commit to gortiz/pinot that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants