Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxLength limiting included for Json Columns #13227

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

deepthi912
Copy link
Collaborator

@deepthi912 deepthi912 commented May 25, 2024

#13123
Fix:

Added code to sanitize the json column to "$SKIPPED$". The way it is in JsonIndex.
Exposed Server metric for the sanitized values (numColsLimitedByMaxLength)
Dependent PR:
#13103

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2024

Codecov Report

Attention: Patch coverage is 55.10204% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 27.87%. Comparing base (59551e4) to head (ef628e9).
Report is 497 commits behind head on master.

Files Patch % Lines
...cal/recordtransformer/SanitizationTransformer.java 71.05% 8 Missing and 3 partials ⚠️
...ain/java/org/apache/pinot/spi/utils/JsonUtils.java 0.00% 4 Missing ⚠️
...a/manager/realtime/RealtimeSegmentDataManager.java 0.00% 3 Missing ⚠️
...a/org/apache/pinot/common/metrics/ServerMeter.java 0.00% 2 Missing ⚠️
...ent/local/recordtransformer/RecordTransformer.java 0.00% 1 Missing ⚠️
...gment/local/segment/creator/TransformPipeline.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13227       +/-   ##
=============================================
- Coverage     61.75%   27.87%   -33.89%     
+ Complexity      207      198        -9     
=============================================
  Files          2436     2533       +97     
  Lines        133233   138904     +5671     
  Branches      20636    21523      +887     
=============================================
- Hits          82274    38713    -43561     
- Misses        44911    97242    +52331     
+ Partials       6048     2949     -3099     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 27.86% <55.10%> (-33.85%) ⬇️
java-21 27.87% <55.10%> (-33.76%) ⬇️
skip-bytebuffers-false 27.86% <55.10%> (-33.89%) ⬇️
skip-bytebuffers-true 27.87% <55.10%> (+0.14%) ⬆️
temurin 27.87% <55.10%> (-33.89%) ⬇️
unittests 27.86% <55.10%> (-33.89%) ⬇️
unittests1 ?
unittests2 27.86% <55.10%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants