Pass literal within AggregateCall via rexList #13282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
added
backward-incompat
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13282 +/- ##
============================================
+ Coverage 61.75% 62.16% +0.40%
+ Complexity 207 198 -9
============================================
Files 2436 2534 +98
Lines 133233 139300 +6067
Branches 20636 21530 +894
============================================
+ Hits 82274 86590 +4316
- Misses 44911 46234 +1323
- Partials 6048 6476 +428
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
reviewed
May 31, 2024
| break; | ||
| default: | ||
| throw new IllegalStateException("Illegal aggregation function operand type: " + operand.getKind()); | ||
| assert operand instanceof RexExpression.Literal; |
There was a problem hiding this comment.
will this be a function call e.g. array of literals?
There was a problem hiding this comment.
It won't be. We only extract literal as operand, others will remain input reference.
Jackie-Jiang
force-pushed
the
aggregation_literal
branch
from
8924721 to
107874c
Compare
xiangfu0
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another try of #13217
PinotAggregateExchangeNodeInsertRule, reconstruct allAggregateCallto carry the literal within the newly createdAggregateCallPinotAggregateExchangeNodeInsertRuleto significantly simplify the special handling inAggregateOperator