[Bug fix] Fix URI construction so that AddSchema command line tool works #13320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verride flag is set to true
suyashpatel98
changed the title
suyashpatel98
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13320 +/- ##
============================================
+ Coverage 61.75% 62.04% +0.29%
+ Complexity 207 198 -9
============================================
Files 2436 2544 +108
Lines 133233 139675 +6442
Branches 20636 21605 +969
============================================
+ Hits 82274 86658 +4384
- Misses 44911 46529 +1618
- Partials 6048 6488 +440
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #13312. Fix URI construction so that AddSchema command line tool works when override flag is set to true
Verified that when the override flag is set to true the schema is overridden successfully
$ bin/pinot-admin.sh AddSchema
-schemaFile /Users/suyash/Desktop/work/open-source/workspace/testData/transcript_schema.json
-controllerHost localhost
-controllerPort 9000
-override=true
-exec
2024/06/05 23:22:22.613 INFO [AddSchemaCommand] [main] Executing command: AddSchema -controllerProtocol http -controllerHost localhost -controllerPort 9000 -schemaFile /Users/suyash/Desktop/work/open-source/workspace/testData/transcript_schema.json -override true _force false -user null -password [hidden] -exec